Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esmvalcore dependency to 2.4.0rc1 #2348

Merged
merged 7 commits into from Oct 20, 2021
Merged

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Oct 18, 2021

Description

Update dependencies in environment.yml and setup.py


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.


To help with the number of pull requests:

@valeriupredoi
Copy link
Contributor

@zklaus nice work, I like the riddance of all those antiquated pins! The good news is that the conda env solves well and fast on the GA machine and we should get #2344 in here then I reckon we'll be in business. There is the Circle tests issue, but let's plug in mamba there 馃榿

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 19, 2021

here's another thing - the editable pip installation worked for me with pip=21.3 after having created a mamba environment with this PR:

valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ conda list python
# packages in environment at /home/valeriu/miniconda3-fresh/envs/core24rc1:
#
# Name                    Version                   Build  Channel
antlr-python-runtime      4.7.2           py39hf3d152e_1002    conda-forge
magics-python             1.5.6              pyhd8ed1ab_0    conda-forge
msgpack-python            1.0.2            py39h1a9c180_1    conda-forge
python                    3.9.7           hb7a2778_3_cpython    conda-forge
python-dateutil           2.8.2              pyhd8ed1ab_0    conda-forge
python-stratify           0.2.post0        py39hce5d2b2_0    conda-forge
python-xxhash             2.0.2            py39h3811e60_0    conda-forge
python_abi                3.9                      2_cp39    conda-forge
valeriu@valeriu-PORTEGE-Z30-C:~/ESMValTool$ conda list pip
# packages in environment at /home/valeriu/miniconda3-fresh/envs/core24rc1:
#
# Name                    Version                   Build  Channel
pip                       21.3               pyhd8ed1ab_0    conda-forge

EDIT agh nevermind, I forgot to blow up me eggs 馃 All's good - it fails as per normal - the eggs were leftover from #2344

@valeriupredoi
Copy link
Contributor

btw forgot to say - I have done some unpinning in #2327 a wee back ago, but chose to pin iris to latest, now that we have it pinned in Core all's fine and I can close that 馃憤

@valeriupredoi
Copy link
Contributor

@zklaus very cool, man! I went through the GA tests, specifically looking at the environments for each platform/OS and Python version - all consistent, and modern, and the usual suspects (nc-time-axis, esmpy, mpich etc) are all nice and modern and looking like not being troublemakers; am gonna remove the test branches in the GA workflows and approve 馃憤 馃嵑

@zklaus zklaus marked this pull request as ready for review October 20, 2021 11:01
@zklaus zklaus added this to the v2.4.0 milestone Oct 20, 2021
@zklaus zklaus self-assigned this Oct 20, 2021
@zklaus zklaus merged commit 06d0b6e into main Oct 20, 2021
@zklaus zklaus deleted the switch-core-to-2.4.0rc1 branch October 20, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants