Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titles in BSC recipes #2351

Merged
merged 7 commits into from
Oct 20, 2021
Merged

Add titles in BSC recipes #2351

merged 7 commits into from
Oct 20, 2021

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Oct 20, 2021

Description

As reported in #2324, recipes now need titles. This PR adds them in recipes contributed by the BSC.
There is also some minor formatting fixes.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @sloosvel - gonna plug this in main if you don't think it really needs a careful scientific review, we need those blithering titles sooner than later 👍

@sloosvel
Copy link
Contributor Author

The titles are not too imaginative, they come from the documentation so I guess they should make sense from a scientific point of view. I forgot one recipe though, added now.

@valeriupredoi valeriupredoi merged commit 2190646 into main Oct 20, 2021
@valeriupredoi valeriupredoi deleted the dev_titles_bsc branch October 20, 2021 10:59
@valeriupredoi
Copy link
Contributor

thx Saskia, no need for Roald Dahl stuff - something the user would need to get an idea of what's happening in that recipe 😃

@jvegreg jvegreg mentioned this pull request Oct 25, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants