Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to recipe embedded in test_diagnostic_run.py #2353

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Oct 20, 2021

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 20, 2021

thanks Klaus! I was thinking we may want to mark this as xfail rather than a full pass since we've still not fixed all the recipes' titles; but at this stage am OK with a full pass, am fed up of seeing all the tests fail coz of the titles thing 😁

@zklaus
Copy link
Contributor Author

zklaus commented Oct 20, 2021

thanks Klaus! I was thinking we may want to mark this as xfail rather than a full pass since we've still not fixed all the recipes' titles; but at this stage am OK with a full pass, am fed up of seeing all the tests fail coz of the titles thing grin

Hm? I don't understand your comment. This is only intended to add one title to one recipe (which happens to be embedded into testing code). Your comment seems far wider reaching?

@valeriupredoi
Copy link
Contributor

nevermind me! I was talking about the test load recipes that currently fails due to missing titles, I went a wee bit over the hills and far away πŸ˜†

@zklaus zklaus merged commit a50fab6 into main Oct 20, 2021
@zklaus zklaus deleted the add-title-to-test-recipe branch October 20, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add title to recipe embedded in test_diagnostic_run.py
2 participants