Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding titles to wenzel recipes #2366

Merged
merged 6 commits into from Oct 22, 2021
Merged

Conversation

hb326
Copy link
Contributor

@hb326 hb326 commented Oct 22, 2021

Description

Adding titles to the recipes from Sabrina Wenzel, and one recipe from Eyring et al., 2013
No issue was opened for this.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated recipe/diagnostic

Adding a title to the recipe.
Adding a title to the recipe.
Adding a title to the recipe.
Adding a title to the recipe.
@zklaus
Copy link
Contributor

zklaus commented Oct 22, 2021

Does this mean that maintainership is being transferred? Or just a one-off helping out?

@hb326
Copy link
Contributor Author

hb326 commented Oct 22, 2021

Does this mean that maintainership is being transferred? Or just a one-off helping out?

Helping out so that we can get the recipes running again for the release. Will have to check with Sabrina how we should proceed since she is not really working in sciency science anymore, but more in science administarion (project management).

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the documentation. Thanks @hb326!

@hb326 hb326 marked this pull request as ready for review October 22, 2021 13:45
@hb326
Copy link
Contributor Author

hb326 commented Oct 22, 2021

Not sure why there are some tests not successful. It seems that there is some problem with the checks of other recipes where the title is not included yet...

Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
@zklaus zklaus merged commit 224ed16 into main Oct 22, 2021
@zklaus zklaus deleted the adding_titles_to_wenzel_recipes branch October 22, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants