Merged
Conversation
Adding a title to the recipe.
Adding a title to the recipe.
Adding a title to the recipe.
Adding a title to the recipe.
Contributor
|
Does this mean that maintainership is being transferred? Or just a one-off helping out? |
Contributor
Author
Helping out so that we can get the recipes running again for the release. Will have to check with Sabrina how we should proceed since she is not really working in sciency science anymore, but more in science administarion (project management). |
remi-kazeroni
approved these changes
Oct 22, 2021
Contributor
remi-kazeroni
left a comment
There was a problem hiding this comment.
This is consistent with the documentation. Thanks @hb326!
Contributor
Author
|
Not sure why there are some tests not successful. It seems that there is some problem with the checks of other recipes where the title is not included yet... |
zklaus
reviewed
Oct 22, 2021
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding titles to the recipes from Sabrina Wenzel, and one recipe from Eyring et al., 2013
No issue was opened for this.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic