Skip to content

Adding titles to wenzel recipes#2366

Merged
zklaus merged 6 commits intomainfrom
adding_titles_to_wenzel_recipes
Oct 22, 2021
Merged

Adding titles to wenzel recipes#2366
zklaus merged 6 commits intomainfrom
adding_titles_to_wenzel_recipes

Conversation

@hb326
Copy link
Copy Markdown
Contributor

@hb326 hb326 commented Oct 22, 2021

Description

Adding titles to the recipes from Sabrina Wenzel, and one recipe from Eyring et al., 2013
No issue was opened for this.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

hb326 added 4 commits October 22, 2021 13:34
Adding a title to the recipe.
Adding a title to the recipe.
Adding a title to the recipe.
Adding a title to the recipe.
@zklaus
Copy link
Copy Markdown
Contributor

zklaus commented Oct 22, 2021

Does this mean that maintainership is being transferred? Or just a one-off helping out?

@hb326
Copy link
Copy Markdown
Contributor Author

hb326 commented Oct 22, 2021

Does this mean that maintainership is being transferred? Or just a one-off helping out?

Helping out so that we can get the recipes running again for the release. Will have to check with Sabrina how we should proceed since she is not really working in sciency science anymore, but more in science administarion (project management).

Copy link
Copy Markdown
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with the documentation. Thanks @hb326!

@hb326 hb326 marked this pull request as ready for review October 22, 2021 13:45
@hb326
Copy link
Copy Markdown
Contributor Author

hb326 commented Oct 22, 2021

Not sure why there are some tests not successful. It seems that there is some problem with the checks of other recipes where the title is not included yet...

Comment thread esmvaltool/recipes/recipe_wenzel16nat.yml Outdated
Co-authored-by: Klaus Zimmermann <klaus.zimmermann@smhi.se>
@zklaus zklaus merged commit 224ed16 into main Oct 22, 2021
@zklaus zklaus deleted the adding_titles_to_wenzel_recipes branch October 22, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants