Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding titles to Bjoern's recipes #2369

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Oct 22, 2021

Description

This PR adds titles to recipes co-maintained by Björn Brötz.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @remi-kazeroni - all good to merge by me

@zklaus
Copy link
Contributor

zklaus commented Oct 22, 2021

I agree with @valeriupredoi, but since @remi-kazeroni asked @bjoernbroetz, @axel-lauer, or @hb326 to weigh in, let's wait for confirmation from any of the four to merge.

@bouweandela
Copy link
Member

Since @bjoernbroetz is no longer working on ESMValTool, would it someone else from DLR took over his role as maintainer of these recipes?

Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titles are fine with me. Thanks @remi-kazeroni!!

@hb326
Copy link
Contributor

hb326 commented Oct 25, 2021

Since @bjoernbroetz is no longer working on ESMValTool, would it someone else from DLR took over his role as maintainer of these recipes?

@bouweandela, we will discuss this. There are a few other recipes that we need to update maintainer-wise as well.

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zklaus zklaus merged commit 2b8d187 into main Oct 25, 2021
@zklaus zklaus deleted the adding_titles_to_bjoern_recipes branch October 25, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants