Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that areacella is needed for area statistics in the Python example recipe #2371

Merged
merged 1 commit into from Oct 22, 2021

Conversation

bouweandela
Copy link
Member

Description

The Python example recipe includes an area statistics preprocessor function. It was not specified that this should use areacella (and not areacello). If a new user without any data available tries to run the recipe with the download option, it will download areacello, which might be confusing. This pull request fixes the problem by specifying which cell measure variable is needed.

See also discussion in ESMValGroup/ESMValCore#1265


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@bouweandela bouweandela added this to the [locked] v2.4.0 milestone Oct 22, 2021
@bouweandela
Copy link
Member Author

@esmvalbot Please run examples/recipe_python.yml

@esmvalbot
Copy link

esmvalbot bot commented Oct 22, 2021

Since @bouweandela asked, ESMValBot will run recipe examples/recipe_python.yml as soon as possible, output will be generated here

@bouweandela bouweandela mentioned this pull request Oct 22, 2021
6 tasks
@esmvalbot
Copy link

esmvalbot bot commented Oct 22, 2021

ESMValBot is happy to report recipe examples/recipe_python.yml ran OK, output has been generated here

@zklaus zklaus merged commit e62c4d5 into main Oct 22, 2021
@zklaus zklaus deleted the improve-example-recipe branch October 22, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants