Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added titles for recipes of maintainer schlund_manuel #2377

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Oct 25, 2021

Added titles for recipes of maintainer schlund_manuel


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Two comments:

  • In yaml, | does multiline strings, keeping the line breaks, perhaps > would be preferable? More info at https://stackoverflow.com/a/21699210
  • In some cases, the title is longer than the description. This feels a bit wrong. Would you mind shortening the title and putting any necessary additional information into the description?

@valeriupredoi
Copy link
Contributor

cheers @schlunma (and welcome back!). I am with @zklaus wrt his comment πŸ˜ƒ

@schlunma
Copy link
Contributor Author

Thanks @zklaus for your comments, I was not aware of the difference between | and >!

@zklaus zklaus merged commit 9361185 into main Oct 25, 2021
@zklaus zklaus deleted the title_for_recipes_schlund branch October 25, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants