write_plots and titles for deangelis15nat, li17natcc, martin18grl, pv_capacity_factor #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2021 22:15
…es for these as well as martin18grl and pv_capacity_factor.
|
All recipes run on Mistral. |
|
I don't understand, why the tests fail? |
|
Thanks for tackling this one, @katjaweigel! Some tests will fail because the tests test for titles in all recipes, so no need to be too alarmed. However, I think you need to merge the latest main into your branch to get fully up to speed here. Could you please do that? |
…r_deangelis_and_li
|
@zklaus Thanks, I overlooked that I did that only for the core. Done and tested on recipe_li17natcc.yml that it still works afterwards. |
|
I am running them on Jasmin. ERA5 complains about lack of data, but the other are running fine. I will let you know when finished |
zklaus
approved these changes
Oct 26, 2021
zklaus
added
documentation
enhancement
and removed
looking for scientific reviewer
labels
|
As this is a purely technical change, scientific review is not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing write_plots for deangelis15nat and li17natcc and adding titles for these as well as martin18grl and pv_capacity_factor.
Description
Sorry I'm late (holidays last week). Here are the titles for the recipes I'm listed as maintainer (recipe_deangelis15nat.yml, recipe_li17natcc.yml, recipe_martin18grl.yml, recipe_pv_capacity_factor.yml, recipes/cmorizers/recipe_era5-land.yml) and removing write plots for the diagnostics, which still contained them (deangelisf1b.py, deangelisf2ext.py, lif1f2.py). Testing on Mistral for the new Core now and therefore started as draft pull request.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: