Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing preprocessor to recipe_gier2020bg and adapt to available data #2399

Merged
merged 4 commits into from Nov 3, 2021

Conversation

bettina-gier
Copy link
Contributor

Found that I forgot to use the preprocessor for unit issues in one diag. Also took the time to comment out all data not currently available on mistral (data downloader didn't work for me) so that the recipe will run on mistral without the need for my additional data folder. Missing data kept in to reflect paper settings!

Yamllint approved ^__^

@zklaus
Copy link
Contributor

zklaus commented Nov 3, 2021

@esmvalbot please run recipe_gier2020bg.yml

@esmvalbot
Copy link

esmvalbot bot commented Nov 3, 2021

Since @zklaus asked, ESMValBot will run recipe recipe_gier2020bg.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Nov 3, 2021

ESMValBot is sorry to report it failed to run recipe recipe_gier2020bg.yml: exit is 1, output has been generated here

@valeriupredoi
Copy link
Contributor

cheers @bettina-gier - could you maybe give it a bit more of a descriptive title please? 🍺

@bettina-gier
Copy link
Contributor Author

Recipe title or pr title?

error from bot is weird.. says it's in the diag log, diag log has no normal errors - only weird thing was a "input in flex scanner failed" in the middle of the print statements which I've never seen before.

@zklaus
Copy link
Contributor

zklaus commented Nov 3, 2021

@bettina-gier, V means PR title. This is what will show up in the changelog.

I am running the recipe manually to check the bot error. Will let you know how it goes.

@bettina-gier bettina-gier changed the title Fix recipe_gier2020bg Add missing preprocessor to recipe_gier2020bg and adapt to available data Nov 3, 2021
@valeriupredoi
Copy link
Contributor

that's the one, PR title, sorry! Cheers, Tina!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments from me 🍺

esmvaltool/recipes/recipe_gier2020bg.yml Outdated Show resolved Hide resolved
esmvaltool/recipes/recipe_gier2020bg.yml Show resolved Hide resolved
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
@zklaus
Copy link
Contributor

zklaus commented Nov 3, 2021

The recipe manually worked; we'll move on.

@zklaus zklaus merged commit acef8dc into main Nov 3, 2021
@zklaus zklaus deleted the fix_gier_recipes branch November 3, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants