Deactivate provenance logging for plots in thermodyn toolbox #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The provenance logging in the Thermodynamic toolbox doesn't work nicely for all plots because individual records are created not for the plot as a whole, but for separate contributing parts, for example separate lines in a line plot.
This is partly because the separate plot parts are created alongside separate, corresponding, individual netcdf files.
The immediate reason why this shows up now is #2296, but the underlying problem was likely present before.
As a workaround for the imminent release, the provenance logging for the affected plots has been commented out, but a better solution should be implemented asap, cf #2413.