-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backwards incompatible changes at the top of the release notes draft #2431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, I don't think we have any for 2.4 - I just used this in the search bar is:closed label:"backwards incompatible change"
and had no returns neither for isues nor PRs (open - just Javi's OBS streamlining); if we don't have any we shouldn't leave an empty section
I thought I already answered this, but my comment appears to have gotten lost. There were 10 backwards-incompatible changes in ESMValCore v2.4. It would be good to clearly list those in the release notes. |
I found the comment #2311 (reply in thread). I guess here would have been a better place to write that. |
Yes, we can regenerate the release notes. To be clear, that would be the release notes for the core only, and we don't intend to make a new (bugfix) release just for that, but just have it in the online documentation and then release it with the next version, right? |
Doing the release notes is always a bit cumbersome because the entries are built from the PRs only based on date, not on the actual commits in the release branch. One day I'd like to change the release notes script to take those into account. |
Awesome!
Yes
Note that there is some software available for doing this kind of thing, maybe we should look at using that instead of rolling our own |
this introduces a fail in the full development tests - multimodel uses |
Description
This adds any backwards-incompatible changes at the top of the draft release notes that can be generated with the draft_release_notes.py tool.
@zklaus Would it be possible to re-generate the release notes for ESMValCore v2.4 with this version of the script? I realized that backwards-incompatible changes are currently hard to find in the changelog.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: