Ensure dummy data for cmorize_obs_woa test are written to the correct directory #2451
Conversation
…correct directory; test module now runs in ~18 seconds
ehogan
added
AutoAssess
|
cheers @ehogan - could you please also add #2452 that this will close too? I'd like to get a confirm from @remi-kazeroni first there that the WOA data structure is correct, the variables dirs seem fishy to me (but I am probably wrong) 🐟 |
valeriupredoi
added
observations
and removed
AutoAssess
valeriupredoi
left a comment
valeriupredoi
left a comment
There was a problem hiding this comment.
cheers for the quick fixes, Emma! I would not do the iris submodule imports here - I know the test won't run in single-test run otherwise, but I'd much more prefer a general fix for all the tests like I did in ESMValGroup/ESMValCore#1367 - in a separate PR, of course 👍
| import sys | ||
|
|
||
| import iris | ||
| from iris import coord_systems, fileformats |
There was a problem hiding this comment.
we should not do this just here but rather have a general fix like here ESMValGroup/ESMValCore#1367
There was a problem hiding this comment.
Why? To me, this makes perfect sense. Something is used here, so it is imported here.
There was a problem hiding this comment.
this #2455 is a slightly more general approach in my view and should secure cases when new tests are written and these imports are omitted
There was a problem hiding this comment.
That PR certainly is more comprehensive. Still, the imports here look like perfectly idiomatic Python to me, so I see no reason to discourage them.
There was a problem hiding this comment.
well OK, I am fine now once I've put together #2455 - I was just afraid I'd forget doing that forever if I let this through - more of a self-reminder hijacking poor Emma's work 😁
|
@valeriupredoi I did have a quick question about this; is there a way to switch off the automatic download of data for tests? The user configuration file used in these tests doesn't request that the data are automatically downloaded, so I wondered if it was different for cmorizers and whether there was an option to switch it off? This would prevent issues like this from happening again :) |
|
@ehogan that's a good idea! The OBS automatic downloads happen through a different mechanism than the CMIP data downloads - something @jvegreg and @remi-kazeroni have worked on feverishly all through the latter part of last year; sadly, I don't know much about how that happens and how to configure it to not do it, Remi, you mind chipping in here please mate? |
I am going to merge this now, close the specific related issues, and open a separate issue about not downloading OBS data in tests should any inconsistencies/faults occur - even if we knew how to implement that (I don't at this point) we shouldn't do it in this PR anyways, but rather, in a more general one 👍 Many thanks for the good work @ehogan 🍺 |
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.