Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed vertical regridding schemes in affected recipes #2487

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jan 18, 2022

Description

This PR renames the vertical regridding schemes that have been changed in ESMValGroup/ESMValCore#1429.

Requires ESMValGroup/ESMValCore#1429; related to ESMValGroup/ESMValCore#1170.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers! AFAIK this also needs a new ESMValCore release right? If so please add the new release needed label 👍

@schlunma
Copy link
Contributor Author

cheers! AFAIK this also needs a new ESMValCore release right? If so please add the new release needed label +1

Correct, my bad! Will merge after the Core PR is merged 👍

@schlunma schlunma added the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Jan 18, 2022
@schlunma schlunma merged commit 1547c81 into main Feb 2, 2022
@schlunma schlunma deleted the rename_vertical_regridding_schemes branch February 2, 2022 14:48
@bouweandela
Copy link
Member

The usual procedure is to only merge PRs that require an updated ESMValCore version after that has been released and made available on conda-forge. It looks like in this case the ESMValCore does not check whether the names of the regridding scheme provided in the recipe are valid, so the ESMValTool unit tests passed even though the new name for the regridding scheme is invalid for the version of ESMValCore that the tests are run with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated feature requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants