Add Python=3.10 to Github Actions and switch to Python=3.10 for the Github Action that builds the PyPi package#2488
Merged
Merged
Conversation
valeriupredoi
changed the title
zklaus
requested changes
Jan 18, 2022
Contributor
zklaus
left a comment
zklaus
left a comment
There was a problem hiding this comment.
LGTM. Just to poke the bear: Why do you say quotes around floats in the commit message? Clearly, you don't consider 3.1 and 3.10 to be the same, so version numbers, as usual, are strings and arguably the bug here is the lack of quotes before.
Anyways, all good now 👍 I'll approve once you are happy enough to remove the branch from the GAs
Contributor
Author
|
yes, no, that's just my annoyance that YAML and I don't think the same way 😆 Thanks dude, I'll remove those tomorrow, am too tired now, but if you can approve pre-emptively I promise I won't make other changes 😁 |
Contributor
Author
|
OK monsieur @zklaus - GA test branches removed, she's all your mate 🍺 |
zklaus
approved these changes
Jan 19, 2022
Contributor
Author
|
many thanks Klaus, you a ⭐ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding python=3.10 to the list of tested for Python versions in the Github Actions runs; note that the GA that builds the PyPi package uses the latest Python version that is now 3.10 so this has changed to 3.10. Sister PR of ESMValGroup/ESMValCore#1430
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.