Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python=3.10 to Github Actions and switch to Python=3.10 for the Github Action that builds the PyPi package #2488

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 18, 2022

Description

Adding python=3.10 to the list of tested for Python versions in the Github Actions runs; note that the GA that builds the PyPi package uses the latest Python version that is now 3.10 so this has changed to 3.10. Sister PR of ESMValGroup/ESMValCore#1430


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the ๐Ÿ›  Technical or ๐Ÿงช Scientific review.

@valeriupredoi valeriupredoi changed the title Add Python=3.10 to Github Actions switch to Python=3.10 for the Github Action that builds the PyPi package Add Python=3.10 to Github Actions and switch to Python=3.10 for the Github Action that builds the PyPi package Jan 18, 2022
Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to poke the bear: Why do you say quotes around floats in the commit message? Clearly, you don't consider 3.1 and 3.10 to be the same, so version numbers, as usual, are strings and arguably the bug here is the lack of quotes before.

Anyways, all good now ๐Ÿ‘ I'll approve once you are happy enough to remove the branch from the GAs

@valeriupredoi
Copy link
Contributor Author

valeriupredoi commented Jan 18, 2022

yes, no, that's just my annoyance that YAML and I don't think the same way ๐Ÿ˜† Thanks dude, I'll remove those tomorrow, am too tired now, but if you can approve pre-emptively I promise I won't make other changes ๐Ÿ˜

@valeriupredoi
Copy link
Contributor Author

OK monsieur @zklaus - GA test branches removed, she's all your mate ๐Ÿบ

@zklaus zklaus self-requested a review January 19, 2022 11:54
@valeriupredoi
Copy link
Contributor Author

many thanks Klaus, you a โญ

@valeriupredoi valeriupredoi merged commit ee4a9b7 into main Jan 19, 2022
@valeriupredoi valeriupredoi deleted the add_py310_GActions branch January 19, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.10 to all Github Actions (Core and Tool)
2 participants