Pin flake8<4 to have actual FLAKE8 error printed if tests fail and not garbage#2492
Merged
valeriupredoi merged 2 commits intomainfrom Feb 2, 2022
Merged
Pin flake8<4 to have actual FLAKE8 error printed if tests fail and not garbage#2492valeriupredoi merged 2 commits intomainfrom
flake8<4 to have actual FLAKE8 error printed if tests fail and not garbage#2492valeriupredoi merged 2 commits intomainfrom
Conversation
4 tasks
Contributor
Author
|
@zklaus frenly ping ma man 😁 |
Contributor
Author
|
@schlunma not a worry, I tagged you here simply for the reason that this shouldn't fall through the cracks and needs to land in v2.5, the test output is really garbled without pinning flake8, if tests fail 🍺 |
zklaus
approved these changes
Feb 2, 2022
Contributor
Author
|
awesome, cheers, Klaus! 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sister PR to ESMValGroup/ESMValCore#1434 and motivated by issue ESMValGroup/ESMValCore#1405 - an example of the garbage the new flake8 spits out can be found in these failed tests
The correctly pinned
flake8will be installed fromesmvalcoreif we merge said PR above before v2.5.0 release but only when we make the release (or when the user installs it in development mode), until then the installation of ESMValTool results in an installation offlake8 = 4.0.1and garbage traces when FLAKE8 tests fail:Also, @zklaus and the release boys @schlunma etc we should be careful the pin is active in the ESMValCore conda feedstock recipe!
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.