Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flake8<4 to have actual FLAKE8 error printed if tests fail and not garbage #2492

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Jan 19, 2022

Description

Sister PR to ESMValGroup/ESMValCore#1434 and motivated by issue ESMValGroup/ESMValCore#1405 - an example of the garbage the new flake8 spits out can be found in these failed tests

The correctly pinned flake8 will be installed from esmvalcore if we merge said PR above before v2.5.0 release but only when we make the release (or when the user installs it in development mode), until then the installation of ESMValTool results in an installation of flake8 = 4.0.1 and garbage traces when FLAKE8 tests fail:

Collecting flake8>=3.5
  Downloading flake8-4.0.1-py2.py3-none-any.whl (64 kB)

Also, @zklaus and the release boys @schlunma etc we should be careful the pin is active in the ESMValCore conda feedstock recipe!


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

@valeriupredoi
Copy link
Contributor Author

@zklaus frenly ping ma man 😁

@valeriupredoi valeriupredoi added this to the v2.5.0 milestone Feb 2, 2022
@valeriupredoi
Copy link
Contributor Author

@schlunma not a worry, I tagged you here simply for the reason that this shouldn't fall through the cracks and needs to land in v2.5, the test output is really garbled without pinning flake8, if tests fail 🍺

@valeriupredoi
Copy link
Contributor Author

awesome, cheers, Klaus! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants