Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authors to citation cff #2525

Merged
merged 6 commits into from
Feb 10, 2022
Merged

Add authors to citation cff #2525

merged 6 commits into from
Feb 10, 2022

Conversation

SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Feb 10, 2022

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

### New or updated recipe/diagnostic

### New or updated data reformatting script


To help with the number of pull requests:

@SarahAlidoost SarahAlidoost marked this pull request as ready for review February 10, 2022 12:57
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @SarahAlidoost - could you please also add Abel Esqueira since he's contributed to both Tool and Core with a nice GA test that checks this very CITATION file, see #2517 Many thanks! Also, it'd be good to have ORCID IDs from Abel, if he's got one attn: @abelsiqueira

@SarahAlidoost
Copy link
Contributor Author

thanks for this @SarahAlidoost - could you please also add Abel Esqueira since he's contributed to both Tool and Core with a nice GA test that checks this very CITATION file, see #2517 Many thanks! Also, it'd be good to have ORCID IDs from Abel, if he's got one attn: @abelsiqueira

Sure, it is added. Thank you :)

CITATION.cff Outdated Show resolved Hide resolved
Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SarahAlidoost!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers, Sarah! 🍺

SarahAlidoost and others added 2 commits February 10, 2022 16:09
Co-authored-by: Abel Siqueira <nepper271@gmail.com>
@schlunma schlunma added this to the v2.5.0 milestone Feb 10, 2022
@schlunma
Copy link
Contributor

@remi-kazeroni you want to add yourself as well here?

@schlunma schlunma merged commit 57135ca into main Feb 10, 2022
@schlunma schlunma deleted the add_authors_to_citation_cff branch February 10, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some authors to CITATION.cff files
5 participants