Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intersphinx mapping #2531

Merged
merged 1 commit into from Feb 14, 2022
Merged

Update intersphinx mapping #2531

merged 1 commit into from Feb 14, 2022

Conversation

zklaus
Copy link
Contributor

@zklaus zklaus commented Feb 14, 2022

Description

The cf-units documentation was moved to readthedocs.org which breaks one of our intersphinx mappings.
This PR fixes that and also takes the opportunity to update the scipy intersphinx mapping to its permanent form after the upstream problem seems to have been fixed.

  • Link to documentation:

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.


To help with the number of pull requests:

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Do we need the same for ESMValCore?

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, man! I believe we're good for Core, I didn't see problems there...better double check tho

@schlunma
Copy link
Contributor

We can probably update the scipy mapping in ESMValCore back to its original value.

@schlunma schlunma merged commit 139a0cd into main Feb 14, 2022
@schlunma schlunma deleted the update-intersphinx-mapping branch February 14, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants