Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated piControl periods for recipes that use KACE-1-0-G #2537

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 16, 2022

Description

This PR corrects wrong piControl periods for some recipes. The original branch_time attributes in the files were wrong. This new information was cross-checked with the modelers.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added this to the v2.5.0 milestone Feb 16, 2022
@schlunma schlunma self-assigned this Feb 16, 2022
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we need to rerun these recipes to make sure everything is right w.r.t this change?

@schlunma
Copy link
Contributor Author

Thanks!! Not necessary now in my opinion, I tested them all about an hour ago. I'm sure we will have another release candidate soon, so we will have to re-test anyway.

@schlunma schlunma merged commit 0a0f901 into main Feb 16, 2022
@schlunma schlunma deleted the fix_some_recipes branch February 16, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants