Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed recipe_kcs.yml #2541

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Fixed recipe_kcs.yml #2541

merged 2 commits into from
Feb 18, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 18, 2022

Description

After some changes in the multi-model preprocessors, the output attributes of the output files changed (e.g., the dataset attribute is set to the name of the original datasets if these are equal, not to MultiModelXXX anymore. This causes recipe_kcs-yml to fail (see e.g. #2223 and this log). This PR fixes this.

The resulting plots look very similar to those in the doc (https://docs.esmvaltool.org/en/latest/recipes/recipe_kcs.html), but it might be good if someone else could double-check this. Thanks!!

After that I will have a look at #2221 and #2223

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added the bug label Feb 18, 2022
@schlunma schlunma added this to the v2.5.0 milestone Feb 18, 2022
@schlunma schlunma self-assigned this Feb 18, 2022
@Peter9192
Copy link
Contributor

Thanks for opening this PR @schlunma! Do you happen to have a link to the new output somewhere? Otherwise I'll try to let the bot run it again

@schlunma
Copy link
Contributor Author

Unfortunately not publicly; running the bot is a good idea!

@Peter9192
Copy link
Contributor

@esmvalbot please run recipe_kcs.yml

@esmvalbot
Copy link

esmvalbot bot commented Feb 18, 2022

Since @Peter9192 asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Feb 18, 2022

ESMValBot is happy to report recipe recipe_kcs.yml ran OK, output has been generated here

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output looks good. Thanks again for the fix! 馃憤

@schlunma schlunma merged commit cc257b9 into main Feb 18, 2022
@schlunma schlunma deleted the fix_recipe_kcs branch February 18, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants