Fix MDER diagnostic regression_stepwise #2545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-lauer
changed the title
schlunma
approved these changes
Feb 21, 2022
Contributor
schlunma
left a comment
schlunma
left a comment
There was a problem hiding this comment.
Just tested this successfully! Output looks good 🎉
Thanks @axel-lauer for fixing this!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the diagnostic
regression_stepwise.nclused byrecipe_wenzel16jclim.yml.The problem is that calculation of the fitting errors fail in the original implementation, which then leads to the NCL drawing functions in
mder_scatter_plotto "hang" indefinitely. In the original implementationcfint2 := sqrt(cfint2 # xx(:, ppt))produces nan as the argument of
sqrtis negative. Changing this line tocfint2 := sqrt(abs(cfint2 # xx(:, ppt)))prevents this problem and the diagnostic runs fine. Output also looks fine to me but needs to be checked carefully by the author.