-
Notifications
You must be signed in to change notification settings - Fork 143
Fix recipe hydrology/recipe_wflow.yml
#2549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remi-kazeroni thank you for the fixes. Now the dem file is for Rhine region instead of Meuse. So, the basin should be changed to Rhine. I couldn't add to the changes, but the values of extract_region should be changed too. Something like:
start_longitude: 5.0
end_longitude: 12.0
start_latitude: 47.25
end_latitude: 52.5Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
|
Thanks for your review @SarahAlidoost! Indeed my changes to the recipe were not fully consistent. Could you please let me know if the latest changes look fine for you? |
SarahAlidoost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remi-kazeroni thanks. The changes look good to me 👍
|
@esmvalbot please run recipe_wflow.yml |
|
Sorry, ESMValBot can not find recipe_wflow.yml recipe in ESMValGroup/ESMValTool repo at fix_recipe_wflow branch, please check that recipe name is correct |
|
@esmvalbot please run hydrology/recipe_wflow.yml |
|
ESMValBot is sorry to report it failed to run recipe hydrology/recipe_wflow.yml: exit is 1, output has been generated here |
|
@esmvalbot please run hydrology/recipe_wflow.yml |
|
Since @remi-kazeroni asked, ESMValBot will run recipe hydrology/recipe_wflow.yml as soon as possible, output will be generated here |
|
I have just changed the |
|
ESMValBot is happy to report recipe hydrology/recipe_wflow.yml ran OK, output has been generated here |
|
@remi-kazeroni Please merge when you are happy with this 👍 |
Description
This PR updates the recipe_wflow.yml using a shape file that is available and changes the documentation accordingly. If that helps, I have already run the recipe successfully using the dem-file mentioned in #2260 (
dem_file: 'wflow_parameterset/wflow_rhine_sbm/staticmaps/wflow_dem.map'), see successful run.Note that I could not store the nc files due to storage limitations on the VM.
hydrology/recipe_wflow.yml#2260Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🛠 Code is written according to the code quality guidelines- [ ] 🛠 The list of authors is up to date- [ ] 🛠 Any changed dependencies have been added or removed correctlyNew or updated recipe/diagnostic
- [ ] 🛠 Provenance information has been addedTo help with the number of pull requests: