Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipe hydrology/recipe_wflow.yml #2549

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Fix recipe hydrology/recipe_wflow.yml #2549

merged 4 commits into from
Feb 23, 2022

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Feb 21, 2022

Description

This PR updates the recipe_wflow.yml using a shape file that is available and changes the documentation accordingly. If that helps, I have already run the recipe successfully using the dem-file mentioned in #2260 (dem_file: 'wflow_parameterset/wflow_rhine_sbm/staticmaps/wflow_dem.map'), see successful run.
Note that I could not store the nc files due to storage limitations on the VM.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remi-kazeroni thank you for the fixes. Now the dem file is for Rhine region instead of Meuse. So, the basin should be changed to Rhine. I couldn't add to the changes, but the values of extract_region should be changed too. Something like:

      start_longitude: 5.0
      end_longitude: 12.0
      start_latitude: 47.25
      end_latitude: 52.5

remi-kazeroni and others added 2 commits February 21, 2022 16:48
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@remi-kazeroni
Copy link
Contributor Author

Thanks for your review @SarahAlidoost! Indeed my changes to the recipe were not fully consistent. Could you please let me know if the latest changes look fine for you?

Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remi-kazeroni thanks. The changes look good to me πŸ‘

@schlunma
Copy link
Contributor

@esmvalbot please run recipe_wflow.yml

@esmvalbot
Copy link

esmvalbot bot commented Feb 23, 2022

Sorry, ESMValBot can not find recipe_wflow.yml recipe in ESMValGroup/ESMValTool repo at fix_recipe_wflow branch, please check that recipe name is correct

@schlunma
Copy link
Contributor

@esmvalbot please run hydrology/recipe_wflow.yml

@esmvalbot
Copy link

esmvalbot bot commented Feb 23, 2022

Since @schlunma asked, ESMValBot will run recipe hydrology/recipe_wflow.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Feb 23, 2022

ESMValBot is sorry to report it failed to run recipe hydrology/recipe_wflow.yml: exit is 1, output has been generated here

@remi-kazeroni
Copy link
Contributor Author

@esmvalbot please run hydrology/recipe_wflow.yml

@esmvalbot
Copy link

esmvalbot bot commented Feb 23, 2022

Since @remi-kazeroni asked, ESMValBot will run recipe hydrology/recipe_wflow.yml as soon as possible, output will be generated here

@remi-kazeroni
Copy link
Contributor Author

I have just changed the auxiliary_data_dir of the bot from @bouweandela's directory to the central directory I maintain on Mistral. This central one should contain everything to run all recipes.

@esmvalbot
Copy link

esmvalbot bot commented Feb 23, 2022

ESMValBot is happy to report recipe hydrology/recipe_wflow.yml ran OK, output has been generated here

@schlunma
Copy link
Contributor

@remi-kazeroni Please merge when you are happy with this πŸ‘

@remi-kazeroni remi-kazeroni merged commit 5b4d362 into main Feb 23, 2022
@remi-kazeroni remi-kazeroni deleted the fix_recipe_wflow branch February 23, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing instructions to download the shape file needed for the hydrology/recipe_wflow.yml
3 participants