Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed provenance tracking for emergent constraint diagnostics #2573

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 4, 2022

Description

In #2296 I forgot to update some of my own diagnostics (i.e., remove the plot_file attribute) 馃槃

Here is a successful run on mistral:

/mnt/lustre01/scratch/b/b309141/work_v2/recipe_schlund20esd_20220305_105907

@remi-kazeroni can you move it to the results from the recent tests (https://esmvaltool.dkrz.de/shared/esmvaltool/v2.5.0-test-rc4/debug.html)? Thanks!!

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added this to the v2.5.0 milestone Mar 4, 2022
@schlunma schlunma self-assigned this Mar 4, 2022
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @schlunma! I have replaced the old run of this recipe by the one you provided for this PR.

@schlunma
Copy link
Contributor Author

schlunma commented Mar 7, 2022

Great, thanks @remi-kazeroni 馃帀

@schlunma schlunma merged commit e599363 into main Mar 7, 2022
@schlunma schlunma deleted the fix_provenance_emergent_constraints branch March 7, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants