Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recipe_wenzel14jgr #2577

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix recipe_wenzel14jgr #2577

merged 1 commit into from
Mar 7, 2022

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Mar 7, 2022

Description

The data nbp_Lmon_HadGEM2-ES_esmHistorical_r1i1p1.nc is no longer available on ESGF (see #2408).

What I did:

  1. First attempt by removing only removing the missing data from the recipe (HadGEM2-ES, exp: esmHistorical, variable: nbp) but that triggered a diagnostic error for diag_gammaHist_Fig3and4. I think the exact same models are needed for some of the variables.

  2. Second attempt by removing (HadGEM2-ES, exp: esmHistorical) for all variables of the diagnostic diag_gammaHist_Fig3and4 but I got an error in the next diagnostic diag_gammaLT_5 which expects data from the HadGEM2-ES model.

  3. Third successful attempt by removing (HadGEM2-ES, exp: esmHistorical) for all variables of the diagnosticsdiag_gammaHist_Fig3and4 and diag_gammaLT_5


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the πŸ›  Technical or πŸ§ͺ Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script

- [ ] πŸ›  Documentation is available
- [ ] πŸ›  The dataset has been added to the CMOR check recipe
- [ ] πŸ§ͺ Numbers and units of the data look physically meaningful


To help with the number of pull requests:

@remi-kazeroni
Copy link
Contributor Author

@axel-lauer and @schlunma please let me know if and how the documentation should be updated. I'm not familiar enough with this recipe to tell myself.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think it's fine to leave the documentation as it is. @axel-lauer What do you think?

@axel-lauer
Copy link
Contributor

Thanks @remi-kazeroni for fixing this! The documentation does not explicitly mention any models, so I would leave it as it is.

@schlunma schlunma merged commit 1a2746c into main Mar 7, 2022
@schlunma schlunma deleted the fix_recipe_wenzel14jgr branch March 7, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants