Skip to content

Conversation

@stacristo
Copy link
Contributor

@stacristo stacristo commented Mar 8, 2022

Description

Implemented documentation improvements

Closes #2458

Links to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

@stacristo stacristo changed the title Based with latest main branch Documentation Improvements Mar 8, 2022
@stacristo
Copy link
Contributor Author

@LisaBock and @remi-kazeroni Since there was an issue with trying to merge the main remote branch to my local branch where I am applying my edits, I created a new request which based on this original pull request: Orignal pull request.

I hope now that this meets the requirements

@remi-kazeroni
Copy link
Contributor

Thanks @stacristo, I think it was the simplest to open a new PR. I will take a look now.

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @stacristo! I think this PR is in good shape and helps improving the clarity of the documentation. I have suggested a couple of improvements, old typos to be fixed and a question to the UET. There is also one subsection that I think was erroneously deleted in this PR. Please let me know if you have any questions or doubts.

@stacristo
Copy link
Contributor Author

Dear @remi-kazeroni , I have implemented based on your recommendations and checked for typos. Hopefully, it can be merged now

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stacristo! Thanks for the changes, the PR looks good to me now. I have pushed a couple of very minor changes to avoid overwriting bits of documentation not touched by this PR. I have left one last suggestion that you might want to consider.

@remi-kazeroni
Copy link
Contributor

It would be good if @LisaBock or @hb326 could have another look at this PR as you have a better overview of the expected changes.

Copy link
Member

@LisaBock LisaBock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stacristo for this!

@remi-kazeroni
Copy link
Contributor

If no further comments on this PR, I plan to merge it by tomorrow evening.

@remi-kazeroni remi-kazeroni merged commit b740d5d into main Mar 24, 2022
@remi-kazeroni remi-kazeroni deleted the documentation_edits branch March 24, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suggestion] Lists of Suggestion for ESMValTool Documentation

4 participants