Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored original versions of recipe_schlund20esd.yml and recipe_meehl20sciadv.yml #2583

Merged
merged 3 commits into from Mar 9, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 9, 2022

Description

To facilitate past releases, I removed some datasets that were not available on Mistral back at the time from the recipes recipe_schlund20esd.yml and recipe_meehl20sciadv.yml (see e.g., #2203). For some reason I also added new datasets that have not been used in the original papers.

Since it is much easier to download missing data now due to the automatic download feature, I restored the original versions of the recipes so that they (almost) 100% correspond to the ones have been used to create the output for the corresponding papers. The only missing variable is cl of CAS-ESM2-0 that fails due to ESMValGroup/ESMValCore#1527. This one is commented and a link to the issue is given.

Here are successful runs on mistral (but we will re-run them with rc5 anyway):

  • /mnt/lustre01/scratch/b/b309141/work_v2/recipe_schlund20esd_20220308_200017
  • /mnt/lustre01/scratch/b/b309141/work_v2/recipe_meehl20sciadv_20220308_220103

All plots are (almost) identical to the ones published in the papers.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 馃洜 Technical or 馃И Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added this to the v2.5.0 milestone Mar 9, 2022
@schlunma schlunma self-assigned this Mar 9, 2022
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it, man! no point running the bot (more so it will be stuck at missing data) if you guys will test with rc5 馃憤

Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me. I ran the recipes to check that data can be downloaded from ESGF and that went fine.

@schlunma
Copy link
Contributor Author

schlunma commented Mar 9, 2022

Thanks guys!

@schlunma schlunma merged commit 6e3f0ec into main Mar 9, 2022
@schlunma schlunma deleted the restore_original_recipes branch March 9, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants