Restored original versions of recipe_schlund20esd.yml and recipe_meehl20sciadv.yml#2583
Merged
Restored original versions of recipe_schlund20esd.yml and recipe_meehl20sciadv.yml#2583
recipe_schlund20esd.yml and recipe_meehl20sciadv.yml#2583Conversation
valeriupredoi
approved these changes
Mar 9, 2022
Contributor
valeriupredoi
left a comment
There was a problem hiding this comment.
go for it, man! no point running the bot (more so it will be stuck at missing data) if you guys will test with rc5 👍
remi-kazeroni
approved these changes
Mar 9, 2022
Contributor
remi-kazeroni
left a comment
There was a problem hiding this comment.
Fine for me. I ran the recipes to check that data can be downloaded from ESGF and that went fine.
Contributor
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To facilitate past releases, I removed some datasets that were not available on Mistral back at the time from the recipes
recipe_schlund20esd.ymlandrecipe_meehl20sciadv.yml(see e.g., #2203). For some reason I also added new datasets that have not been used in the original papers.Since it is much easier to download missing data now due to the automatic download feature, I restored the original versions of the recipes so that they (almost) 100% correspond to the ones have been used to create the output for the corresponding papers. The only missing variable is
clofCAS-ESM2-0that fails due to ESMValGroup/ESMValCore#1527. This one is commented and a link to the issue is given.Here are successful runs on mistral (but we will re-run them with rc5 anyway):
/mnt/lustre01/scratch/b/b309141/work_v2/recipe_schlund20esd_20220308_200017/mnt/lustre01/scratch/b/b309141/work_v2/recipe_meehl20sciadv_20220308_220103All plots are (almost) identical to the ones published in the papers.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: