-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update monitor diagnostics #2608
Conversation
Could anyone take a look at this? It would be nice to merge this soon since I have a follow-up PR that extends the monitoring diagnostic with an additional plot type. |
apologies, but I am a bit packed with another couple of diags! If you are in a hurry feel free to ask someone else to review, else I'll take a look as soon as I am done with those tasks. |
No worries, just wanted to make sure that we don't forget about this! |
Taking a look on this on monday! sorry for the delay |
Having the smoothed versions in a separate plot is fine for me. I also spoke to the maintainer of mapgenerator, if any of you wants to contribute changes for the monitor diags into the package feel free to do so. Just don't expect a lot of involvement to keep up with ESMValTool needs because it's an internal package that is mostly used by other groups in the dept, but if you feel like contributing go for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes look fine to me and do not break anything. I could run the recipe setting several output files types without any kind of issue. As mentioned, if you want to contribute the plot changes to mapgenerator you can, but it's not necessary.
Thanks for the review Saskia! 🎉
I agree, that shouldn't be necessary. |
Description
This PR updates the monitoring diagnostic.
{plot_dir}
(default ESMValTool plot directory) in the recipe.output-file-type
for all plots.rasterize_maps=False
(defaultTrue
). Note that I had to implement this viaArtist.set_rasterized(True)
since it's not possible to pass arbitrary keyword arguments (and thusrasterized=True
) to the plotting function in mapgenerator.plot_cube
. I changed that so that the smoothed version gets plotted in a separate plot. Feel free to suggest any alternatives, but note that maybe an update ofmapgenerator
is necessary for that.suptitle
positions because the titles were sometimes overlapping, especially for stereographic plots.recipe_monitor.yml
is sometimes hardcoded instead of configurable #2561Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: