-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved handling of weights in MLR diagnostics #2625
Conversation
@valeriupredoi Would you mind giving this a brief technical review? This basically only improves the documentation and error messages. I successfully tested all affected recipes; the output of them is the same as for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking nice, cheers, dude! Just a couple very minor wiggles from me 🍺
Cheers, thanks V.!! |
Description
weighted_samples
for MLR diagnostics: Ifweighted_samples
is not given, do not use weights.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: