Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of weights in MLR diagnostics #2625

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Improved handling of weights in MLR diagnostics #2625

merged 6 commits into from
Apr 12, 2022

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Apr 7, 2022

Description

  • Change the default value of weighted_samples for MLR diagnostics: If weighted_samples is not given, do not use weights.
  • Raise error if weights cannot be calculated but are requested by the user.
  • Update API doc of the functions that calculate weights.

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@schlunma schlunma added this to the v2.6.0 milestone Apr 7, 2022
@schlunma schlunma self-assigned this Apr 7, 2022
@taly-pereira taly-pereira marked this pull request as ready for review April 8, 2022 07:34
@schlunma
Copy link
Contributor Author

@valeriupredoi Would you mind giving this a brief technical review?

This basically only improves the documentation and error messages. I successfully tested all affected recipes; the output of them is the same as for the main branch. Thanks!!

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking nice, cheers, dude! Just a couple very minor wiggles from me 🍺

esmvaltool/diag_scripts/mlr/__init__.py Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/mlr/preprocess.py Outdated Show resolved Hide resolved
@schlunma
Copy link
Contributor Author

Cheers, thanks V.!!

@schlunma schlunma merged commit 33803ae into main Apr 12, 2022
@schlunma schlunma deleted the mlr_updates branch April 12, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of sample weights in MLR diagnostics can be confusing
3 participants