Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype for Marrmot recipe results #2646

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix dtype for Marrmot recipe results #2646

merged 1 commit into from
Jun 9, 2022

Conversation

SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented May 3, 2022

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script


To help with the number of pull requests:

@SarahAlidoost SarahAlidoost marked this pull request as ready for review May 3, 2022 16:00
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SarahAlidoost - looks good technically; note that CMOR standards say data should be float32 and coordinates' points float64, so not sure why the high precision here, but that's diag-specific stuff am guessing 👍

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this solved our problems with running marrmot.

@SarahAlidoost
Copy link
Contributor Author

thanks @SarahAlidoost - looks good technically; note that CMOR standards say data should be float32 and coordinates' points float64, so not sure why the high precision here, but that's diag-specific stuff am guessing +1

Thanks for reviewing.

@bouweandela bouweandela merged commit 33c5c61 into main Jun 9, 2022
@bouweandela bouweandela deleted the fix_marrmot_dtype branch June 9, 2022 14:00
@sloosvel sloosvel added this to the v2.6.0 milestone Jul 22, 2022
@sloosvel sloosvel added the bug label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix numpy dtype for Marrmot recipe results
5 participants