-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collecting github user names for config-references #2677
Conversation
good call! I added meself too - I wanted to add others too that I know their GH handles but then I thought I might break some GDPR rules 😁 |
BTW we should get a Github Action workflow done that checks the validity of this file like we have for CITATION, I can do that |
Adding Liza's full affiliation
@valeriupredoi, do you plan to do it in this PR or will you open another one? I have no experience with GitHub actions, but I could try to create a yamale schema file if that helps. |
@lukruh thanks for all the work you done here! I'll do that in a separate PR 👍 |
I wonder if I have to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ;)
Couldn't find typos. and the matter of "von Hardenberg" and "de Mora" where to put them alphabetically I guess doesn't matter as long as it's consistent ^^
Indeed this is only necessary when updating CITATION.cff. Unfortunately, the two sources of contributors are not synchronized, see #1616. |
Description
This PR collects changes to config-references until end of June.
For Details see Issue #2676. The list of authors can be found and edited here.
An example entry with the new optional
github
field could look like this:Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number of pull requests: