Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collecting github user names for config-references #2677

Merged
merged 20 commits into from
Jul 11, 2022
Merged

Conversation

lukruh
Copy link
Contributor

@lukruh lukruh commented Jun 15, 2022

Description

This PR collects changes to config-references until end of June.
For Details see Issue #2676. The list of authors can be found and edited here.

An example entry with the new optional github field could look like this:

doe_jane:
  name: Doe, Jane
  institute: Jane Doe Institute
  orcid:
  email: jane.doe@email.com
  github: jd123

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@lukruh lukruh changed the title [DO NOT MERGE YET] github users for config-references [DO NOT MERGE] github users for config-references Jun 15, 2022
@lukruh lukruh changed the title [DO NOT MERGE] github users for config-references [DO NOT MERGE] collect github user names for config-references Jun 15, 2022
@lukruh lukruh marked this pull request as draft June 15, 2022 12:41
@lukruh lukruh changed the title [DO NOT MERGE] collect github user names for config-references collecting github user names for config-references Jun 15, 2022
@valeriupredoi
Copy link
Contributor

good call! I added meself too - I wanted to add others too that I know their GH handles but then I thought I might break some GDPR rules 😁

@valeriupredoi
Copy link
Contributor

BTW we should get a Github Action workflow done that checks the validity of this file like we have for CITATION, I can do that

@lukruh
Copy link
Contributor Author

lukruh commented Jun 30, 2022

BTW we should get a Github Action workflow done that checks the validity of this file like we have for CITATION, I can do that

@valeriupredoi, do you plan to do it in this PR or will you open another one? I have no experience with GitHub actions, but I could try to create a yamale schema file if that helps.

@valeriupredoi
Copy link
Contributor

@lukruh thanks for all the work you done here! I'll do that in a separate PR 👍

@lukruh
Copy link
Contributor Author

lukruh commented Jul 1, 2022

I wonder if I have to run
cffconvert --ignore-suspect-keys --outputformat zenodo --outfile .zenodo.json. I haven't touched CITATION.cff

Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;)
Couldn't find typos. and the matter of "von Hardenberg" and "de Mora" where to put them alphabetically I guess doesn't matter as long as it's consistent ^^

@bouweandela
Copy link
Member

I wonder if I have to run
cffconvert --ignore-suspect-keys --outputformat zenodo --outfile .zenodo.json. I haven't touched CITATION.cff

Indeed this is only necessary when updating CITATION.cff. Unfortunately, the two sources of contributors are not synchronized, see #1616.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an optional github user field to config-references - Initial collection DEADLINE: June 30
10 participants