Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iris-esmf-regrid as a dependency #2880

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Add iris-esmf-regrid as a dependency #2880

merged 3 commits into from
Oct 25, 2022

Conversation

zklaus
Copy link

@zklaus zklaus commented Oct 25, 2022

Description

This simply adds iris-esmf-regrid as a dependency, making it easily available for regridding. We do not, so far, use it in any integrated recipes yet.

  • Closes #issue_number

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@zklaus zklaus marked this pull request as ready for review October 25, 2022 10:57
@zklaus zklaus added this to the v2.7.0 milestone Oct 25, 2022
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @zklaus 🍺

@valeriupredoi valeriupredoi merged commit c9d8580 into main Oct 25, 2022
@valeriupredoi valeriupredoi deleted the add-iris-esmf branch October 25, 2022 11:05
@bouweandela
Copy link
Member

@zklaus Wouldn't it make more sense to add iris-esmf-regrid as a dependency to esmvalcore instead?

@valeriupredoi
Copy link
Contributor

@bouweandela fairly sure Klaus will, but I hurried him up a bit so I can have it plopped in the release; same as with iris that is in both Core and Tool requirements - it'll be used in diags too

@zklaus
Copy link
Author

zklaus commented Oct 27, 2022

Actually, I thought a little bit about it and decided against that. The reason is that it is really not used in the core, but just something made available for recipe developers. I didn't think too long though and have not developed strong feelings about it, so it's open for discussion.

@bouweandela
Copy link
Member

Let's talk about it at the next tech lead team meeting then: ESMValGroup/Community#56 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants