[Issue]: Diskmode not detected in Citrix VDA 2303

[chezzer64]

Describe the bug

Running Citrix VDA v2303 in an MCS environment, it looks like Citrix have changed the name of 'Personality.ini' to 'MCSPersonality.ini' which results in BIS-F Diskmode detection not working.
I haven't been able to test if this would also impact PVS environments - maybe PVS retains the Personality.ini name?

Steps to reproduce

1. Install Citrix VDA 2303 and configure for MCS provisioning.
2. Confirm Citrix Personality file is now created as C:\MCSPersonality.ini.
3. BIS-F diskmode check logic can't find 'Personality.ini' so the diskmode is identified as 'Unmanaged'

Expected behavior

Update BIS-F to check for 'Personality.ini' or 'MCSPesonality.ini' to determine current diskmode.

Screenshots

Desktop, please complete the following information.

OS: Win10
Citrix VDA: v2303

Smartphone, please complete the following information.

No response

Additional context

No response

[chezzer64]

As a temporary workaround, in my environment, I've updated the following code in BISF.psm1.
if (Test-Path -Path "C:\Personality.ini" -PathType Leaf) { $Personality = Get-Content -Path "C:\Personality.ini" foreach ($line in $Personality) { if ($line -like '*DiskMode=*') { $Line = $Line.split("=") $returnValue = "VDA" + $Line[1] } } IF ($LIC_BISF_CLI_P2V_PT -eq "1") { $returnValue = $ReturnValue + "UNC-Path" } } elseif (Test-Path -Path "C:\MCSPersonality.ini" -PathType Leaf) { $Personality = Get-Content -Path "C:\MCSPersonality.ini" foreach ($line in $Personality) { if ($line -like '*DiskMode=*') { $Line = $Line.split("=") $returnValue = "VDA" + $Line[1] } } IF ($LIC_BISF_CLI_P2V_PT -eq "1") { $returnValue = $ReturnValue + "UNC-Path" } } else { $returnValue = "Unmanaged" IF ($LIC_BISF_CLI_P2V_PT -eq "1") { $returnValue = $ReturnValue + "UNC-Path" } }

I know personality.ini is referenced in other BIS-F scripts but I think those other references may be specific to PVS. Not sure if those references would need updating until we can get confirmation on if personality.ini name changes when using PVS with VDA v2303.

[jeremyts]

It was actually simpler to resolve in the BISF.psm1 like this....
$FilePath = Get-ChildItem -Path "${env:SYSTEMDRIVE}\" -Filter '*Personality.ini' | Where-Object {$_.Extension -eq ".ini"} | Sort-Object -Property LastWriteTime -Descending | Select-Object -First 1 if ($null -ne $FilePath) { $Personality = Get-Content -Path $FilePath.FullName

[matthias-schlimm]

in a PVS environment we will have both ini

[matthias-schlimm]

Update Code as follows should be possible:

$FilePath = Get-ChildItem -Path "${env:SYSTEMDRIVE}\" -Filter '*Personality.ini' | Where-Object {$_.Extension -eq ".ini"} | Sort-Object -Property LastWriteTime -Descending | Select-Object -First 1
if ($null -ne $FilePath) { $Personality = Get-Content -Path $FilePath.FullName}