Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EarthWorks v2.1.001 Branch #32

Merged
merged 5 commits into from
Mar 13, 2024
Merged

EarthWorks v2.1.001 Branch #32

merged 5 commits into from
Mar 13, 2024

Conversation

gdicker1
Copy link
Contributor

Incorporate PRs and fixes in externals

Incorporate EarthWorksOrg/mpas-framework PR #6
@gdicker1
Copy link
Contributor Author

gdicker1 commented Feb 21, 2024

@gdicker1 gdicker1 self-assigned this Feb 21, 2024
@gdicker1 gdicker1 changed the title [Draft] Fix Issues After EarthWorks v2.1 Release EarthWorks v2.1.001 Branch Mar 6, 2024
@gdicker1 gdicker1 added the release Related to a release version of the code label Mar 6, 2024
@gdicker1 gdicker1 changed the base branch from main to develop March 6, 2024 18:07
@dazlich
Copy link
Contributor

dazlich commented Mar 6, 2024

I tested the 32L 120km fully-coupled model. Builds and runs for intel, gnu, and nvhpc compilers on cpu.

Has a build issue with intel-oneapi:
ERROR: Command: '/glade/u/home/dazlich/ewv2.1/post_relv21/components/cam/bld/configure -s -fc_type intel-oneapi -dyn mpas -hgrid mpasa120 -cpl nuopc -usr_src /glade/derecho/scratch/dazlich/frametest.intel-oneapi/SourceMods/src.cam -spmd -nosmp -ocn mpaso -dyn mpas -nlev=32 -mpas_libdir /glade/derecho/scratch/dazlich/frametest.intel-oneapi/bld/atm/obj/mpas' failed with error 'ERROR: intel-oneapi is not a valid value for parameter fc_type: valid values are cray,pgi,intel,gnu,pathscale,ibm,nag,nvhpc,pgi-gpu,nvhpc-gpu' from dir '/glade/derecho/scratch/dazlich/frametest.intel-oneapi/Buildconf/camconf'

@gdicker1
Copy link
Contributor Author

gdicker1 commented Mar 6, 2024

I tested the 32L 120km fully-coupled model. Builds and runs for intel, gnu, and nvhpc compilers on cpu.

Has a build issue with intel-oneapi: ERROR: Command: ...

Thanks for testing, @dazlich!

It looks like the issue comes from the CAM side in the bld/config_files
/definition.xml file: Lines 224-227 which doesn't include intel-oneapi. We've been able to build/run with this compiler before, right?

<entry id="fc_type" valid_values="cray,pgi,intel,gnu,pathscale,ibm,nag,nvhpc,pgi-gpu,nvhpc-gpu" value="">
Type of Fortran compiler.  Used when -fc specifies a generic wrapper script
such as mpif90 or ftn.
</entry>

@dazlich
Copy link
Contributor

dazlich commented Mar 6, 2024 via email

@gdicker1
Copy link
Contributor Author

gdicker1 commented Mar 6, 2024

I would guess it's this change below in CAM/bld/configure

Previously:

if ($fc_type == "oneapi") {$fc_type = 'intel'; }

Changed to in EWOrg/CAM PR#14. Link to line in PR#14

if ($fc_type eq "oneapi") {$fc_type = 'intel'; }

@gdicker1
Copy link
Contributor Author

gdicker1 commented Mar 8, 2024

Edited this comment above to change the MPAS-SI PR from EWOrg/MPAS-SI #7 to EWOrg/MPAS-SI #8

@gdicker1
Copy link
Contributor Author

gdicker1 commented Mar 8, 2024

NOTE: this PR now needs to add #35 to the issues and EWOrg/CAM #15 to the PRs

@gdicker1
Copy link
Contributor Author

gdicker1 commented Mar 8, 2024

Edited this comment above to add #35 and EWOrg/CAM #15

@gdicker1
Copy link
Contributor Author

...

Dropping references to Perlmutter from this comment according to discussion and commit 8558c58

@gdicker1 gdicker1 merged commit 258a4d4 into develop Mar 13, 2024
@gdicker1 gdicker1 deleted the update/post_relv21 branch April 23, 2024 23:16
gdicker1 added a commit to gdicker1/EarthWorks that referenced this pull request Sep 10, 2024
Use PR branch from EarthWorksOrg/CAM EarthWorksOrg#32 to use more descriptive ESMF
timers within parts of the CAM code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to a release version of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants