Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier Multiple Database providers and small Rhisis.Database refactor #208

Merged
merged 11 commits into from May 16, 2019

Conversation

3 participants
@MarkWilds
Copy link
Contributor

commented Apr 25, 2019

I am mainly using PostgreSQL and wanted this project to have easier mutliple DB provider support.
The Rhisis.Database project is a bit refactored and a little leaner, each migration compatibility set resides in it's own assembly.

Current migrations assemblies:
Rhisis.PostgreSQL (PostgreSQL)
Rhisis.MsySQL (MySQL and MsSQL)

Updating database:
cd src/Rhisis.PostgreSQL (or any other migration assembly)
dotnet ef database update -s ../Rhisis.World

Try to see if it works on your configuration.

Updated all other projects to reflect my changes.

@MarkWilds

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Still testing and solving errors

@MarkWilds MarkWilds closed this Apr 26, 2019

Removed all using(IDisposable) database resolves, as
the IOC container from .net core should manage this itself.
@MarkWilds

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Fixed most errors and issues I could find.
Would be glad if an MsSQL or MySQL user could test my changes.
I Tested myself, but I am new to this project. Just to be sure.

@MarkWilds MarkWilds reopened this Apr 26, 2019

@CineXMike
Copy link

left a comment

Working


<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<RootNamespace>PostgreSQL</RootNamespace>

This comment has been minimized.

Copy link
@Eastrall

Eastrall May 9, 2019

Owner

Maybe it should be: Rhisis.PostgreSQL ? what do you think ?

This comment has been minimized.

Copy link
@MarkWilds

MarkWilds May 9, 2019

Author Contributor

Yeah, good find, my guess is also I can remove those in the projects and start using assembly name root namespace.

This comment has been minimized.

Copy link
@Eastrall

Eastrall May 9, 2019

Owner

Yes, I guess you can remove it from the csproj and use the assembly namespace, which would be something like: Rhisis.PostgreSQL by default.
Now that I am thinking about it, shouldn't be better if we name the assemblies : Rhisis.Database.ProstgreSQL / Rhisis.Database.MysSQL ?

@Eastrall Eastrall added this to In progress in Rhisis Board via automation May 9, 2019

MarkWilds added some commits May 9, 2019

@Eastrall Eastrall moved this from In progress to Needs review in Rhisis Board May 14, 2019

Rhisis Board automation moved this from Needs review to Reviewer approved May 16, 2019

@Eastrall Eastrall merged commit 156134b into Eastrall:develop May 16, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Rhisis Board automation moved this from Reviewer approved to Done May 16, 2019

@MarkWilds MarkWilds deleted the MarkWilds:feature/multiple_db_providers branch May 16, 2019

@Eastrall Eastrall referenced this pull request May 29, 2019

Merged

Version 0.2 #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.