Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPC loading and update timestep #220

merged 1 commit into from May 26, 2019


1 participant
Copy link

commented May 25, 2019

This PR fixes the NPC loading by adding the CommonControlDyoElement class that loads a common control from the official DYO files. All NPCs weren't loading because there was a CommonControl element in the middle of the file that needed to be handled.

Also, this PR provides fixes to the map instance game loop.

@Eastrall Eastrall added this to the Version 0.2 milestone May 25, 2019

@Eastrall Eastrall self-assigned this May 25, 2019

@Eastrall Eastrall added this to In progress in Rhisis Board via automation May 25, 2019

@Eastrall Eastrall merged commit cd9bb31 into develop May 26, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

Rhisis Board automation moved this from In progress to Done May 26, 2019

@Eastrall Eastrall deleted the update branch May 26, 2019

@Eastrall Eastrall referenced this pull request May 29, 2019


Version 0.2 #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.