Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the more specific overload of PropertyAccessor for twig renderEntityField #2921

Open
gisostallenberg opened this issue Sep 7, 2019 · 2 comments

Comments

@gisostallenberg
Copy link
Contributor

commented Sep 7, 2019

Short description of what this feature will allow to do:
It would be nice if it was possible to use serialization to get the data from an entity, but as mentioned in #1648 you don't feel like implementing it, which is fine. I understand your point of view. It would be really great though if it was made easier to add serialization by yourself. At the moment it can be done, but requires decorating or replacing the property_accessor service, which I think is to broad.
Allowing others to do this could be achieved in 3 ways:

  1. Define a separate service for this, which encapsulates property_accessor
  2. Add a separate alias for property_accessor and use that as argument, so only this specific service can be replaced or decorated
  3. Use the already available easyadmin.property_accessor service as argument

Also see https://github.com/EasyCorp/EasyAdminBundle/blob/master/src/Resources/config/services.xml#L45

@gisostallenberg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

@javiereguiluz Would you like me to create a PR? For which solution?

@gisostallenberg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Created a PR for approach 2, because I think it is the best solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.