Fix ExceptionListener @final deprecation #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
require #2723 |
|
Thanks. |
javiereguiluz
added a commit
that referenced
this pull request
May 14, 2019
This PR was merged into the 2.0.x-dev branch. Discussion ---------- Fix ExceptionListener @Final deprecation https://travis-ci.org/EasyCorp/EasyAdminBundle/jobs/531004595#L817 ```bash 1x: The "Symfony\Component\HttpKernel\EventListener\ExceptionListener" class is considered final since Symfony 4.3. It may change without further notice as of its next major version. You should not extend it from "EasyCorp\Bundle\EasyAdminBundle\EventListener\ExceptionListener". 1x in ExceptionListenerTest::testCatchBaseExceptions from EasyCorp\Bundle\EasyAdminBundle\Tests\EventListener 1x: The "EasyCorp\Bundle\EasyAdminBundle\EventListener\ExceptionListener::onKernelException()" method will require a new "string $eventName" argument in the next major version of its parent class "Symfony\Component\HttpKernel\EventListener\ExceptionListener", not defining it is deprecated. 1x in ExceptionListenerTest::testCatchBaseExceptions from EasyCorp\Bundle\EasyAdminBundle\Tests\EventListener 1x: The "EasyCorp\Bundle\EasyAdminBundle\EventListener\ExceptionListener::onKernelException()" method will require a new "EventDispatcherInterface $eventDispatcher" argument in the next major version of its parent class "Symfony\Component\HttpKernel\EventListener\ExceptionListener", not defining it is deprecated. 1x in ExceptionListenerTest::testCatchBaseExceptions from EasyCorp\Bundle\EasyAdminBundle\Tests\EventListener ``` I'm not sure we should care about BC here (it can be simplified even more) The injection of a custom controller to this class seems like a rare extreme case; most of the time you should override the `@EasyAdmin/default/exception.html.twig` template. Commits ------- 35dbf20 Fix ExceptionListener final deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://travis-ci.org/EasyCorp/EasyAdminBundle/jobs/531004595#L817
I'm not sure we should care about BC here (it can be simplified even more)
The injection of a custom controller to this class seems like a rare extreme case; most of the time you should override the
@EasyAdmin/default/exception.html.twigtemplate.