Allow to define security permissions for menu items #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndench
approved these changes
Jun 30, 2019
yceruto
approved these changes
Jul 1, 2019
javiereguiluz
added a commit
that referenced
this pull request
Jul 1, 2019
…viereguiluz) This PR was merged into the 2.0.x-dev branch. Discussion ---------- Allow to define security permissions for menu items This is the first of a series of pull request that will add security/permissions to every part of the backends. This PR only adds permissions to menu items. I know you need more permissions in other parts of the bundle, but those will be added in future PRs. Commits ------- 56f4a82 Allow to define security permissions for menu items
javiereguiluz
added a commit
that referenced
this pull request
Jul 6, 2019
…luz) This PR was squashed before being merged into the 2.0.x-dev branch (closes #2810). Discussion ---------- Add security permissions to the "list" view This continues the work started in #2806. First, you can show/hide entire columns of the list view based on user roles. Second, you can hide entire item rows based on user permissions. The idea would be to define the `item_permission` option and create a security voter yourself to control which items can users view. This is how it'd look when there are items which you don't have permission to view:  And when you "mouse over" them _(the GIF looks ugly because the subtle gray background of empty rows is not displayed)_:  The last step would be to allow/disallow the entire "list" action ... that's more complex because we already have "disallowed actions" config. We may reuse that, deprecate that or add something in addition to that. We'll see. Commits ------- c3528ac Add security permissions to the \"list\" view
javiereguiluz
added a commit
that referenced
this pull request
Jul 8, 2019
…reguiluz) This PR was squashed before being merged into the 2.0.x-dev branch (closes #2829). Discussion ---------- Allow to configure permissions for show/edit/new In #2806 we added permissions to menus. In #2810 we added permissions to list/search. This PR completes the security feature adding permissions to show/edit/new. Commits ------- 5417699 Allow to configure permissions for show/edit/new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of a series of pull request that will add security/permissions to every part of the backends.
This PR only adds permissions to menu items. I know you need more permissions in other parts of the bundle, but those will be added in future PRs.