Replace ee-nginx-proxy with EE_PROXY_TYPE constant #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbtamuli
previously approved these changes
Sep 24, 2018
mrrobot47
requested changes
Sep 24, 2018
Member
mrrobot47
left a comment
mrrobot47
left a comment
There was a problem hiding this comment.
Do a full search in this package as well as other packages and see if anywhere ee-nginx-proxy is directly written instead of using the constant.
For example there are changes needed here: https://github.com/EasyEngine/easyengine/blob/develop-v4/php/EE/Migration/Containers.php#L141-L146
As well as at other places in this file. There may be more in other packages.
kirtangajjar
changed the title
kirtangajjar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on EasyEngine/service-command#5. Make sure to merge both PRs together.