Rename publish help messages to share help messages #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mbtamuli
suggested changes
Dec 25, 2018
Contributor
There was a problem hiding this comment.
grep -irn 'publish' | grep 'EE::'
src/helper/class-ee-site.php:1038: EE::error( 'Could not publish site.' );
src/helper/class-ee-site.php:1040: EE::success( "Successfully shared {$this->site_data->site_url} to url: $published_url" );
src/helper/class-ee-site.php:1112: EE::error( 'Could not publish site. Please check logs.' );
src/helper/class-ee-site.php:1118: EE::log( 'Disabling publish.' );
src/helper/hooks.php:83:EE::add_hook( 'site_cleanup', 'cleanup_publishing' );These messages got left behind.
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mbtamuli
suggested changes
Dec 25, 2018
src/helper/class-ee-site.php
Outdated
| $error = $refresh ? '' : "{$this->site_data->site_url} has already been shared. Visit link: $publish_url to view it online.\nNote: This link is only valid for few hours. In case it has expired run: `ee site share {$this->site_data->site_url} --refresh`"; | ||
| } else { | ||
| $error = "$active_publish site is published currently. Publishing of only one site at a time is supported.\nTo publish {$this->site_data->site_url} , first run: `ee site publish $active_publish --disable`"; | ||
| $error = "$active_publish site is shared currently. Sharing of only one site at a time is supported.\nTo publish {$this->site_data->site_url} , first run: `ee site share $active_publish --disable`"; |
Contributor
There was a problem hiding this comment.
Suggested change
| $error = "$active_publish site is shared currently. Sharing of only one site at a time is supported.\nTo publish {$this->site_data->site_url} , first run: `ee site share $active_publish --disable`"; | |
| $error = "$active_publish site is shared currently. Sharing of only one site at a time is supported.\nTo share {$this->site_data->site_url} , first run: `ee site share $active_publish --disable`"; |
Contributor
There was a problem hiding this comment.
There's also a publish word in line 1070 @mrrobot47
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mbtamuli
approved these changes
Dec 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Riddhesh Sanghvi riddheshsanghvi96@gmail.com