Potential LhFreeMemory call on random pointer #38

Closed
pzychotic opened this Issue Aug 29, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@pzychotic

Hi,

in LhAllocateHook() the variable Hook isn't initialized with NULL and the first assignment is only done after three potential THROW calls.
So we might end in the THROW_OUTRO happily passing the null pointer check and calling LhFreeMemory() on a random pointer.

@spazzarama spazzarama added the bug label Aug 30, 2015

@spazzarama spazzarama added this to the 2.7 Stable milestone Aug 30, 2015

@spazzarama

This comment has been minimized.

Show comment
Hide comment
@spazzarama

spazzarama Aug 30, 2015

Member

Thanks @pzychotic - I've run through and checked every other compiler warning and addressed appropriately also.

Member

spazzarama commented Aug 30, 2015

Thanks @pzychotic - I've run through and checked every other compiler warning and addressed appropriately also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment