Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow library location to be chosen #221

Merged
merged 4 commits into from Jan 4, 2018

Conversation

life-coder
Copy link
Contributor

As said in #220 here is the pull request, please review it and tell me if any more changes should be made

@life-coder
Copy link
Contributor Author

Hmmm, maybe I should change the other projects too so the appveyor build succeeds

@justinstenning
Copy link
Member

justinstenning commented Jan 4, 2018

Not keen on changing the public signature of that method, however adding it as a property on the Config static class instead?

Not the best from a design stance, but at least the impact is low.

@life-coder
Copy link
Contributor Author

Hmmm okay

@life-coder
Copy link
Contributor Author

Just so I'm sure I understand it correctly. I add a property to the EasyHook.Config static class called: "HelperLibrariesLocation" which will then be used instead of "Path.GetDirectoryName(typeof(Config).Assembly.Location)" and either the property returns the user defined location if any or it returns the same path the current function would return

@justinstenning
Copy link
Member

Correct

@life-coder
Copy link
Contributor Author

It became a bit of a mess but this should do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants