Skip to content

[fix] Add missing address parameters to Shipment create parameter set #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

[fix] Add missing address parameters to Shipment create parameter set #516

merged 1 commit into from
Sep 5, 2023

Conversation

@nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Sep 5, 2023

Description

  • Add missing optional return_address and buyer_address parameters for Shipment creation parameter sets

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team September 5, 2023 20:13
@nwithan8 nwithan8 merged commit bf1ed28 into master Sep 5, 2023
@nwithan8 nwithan8 deleted the return_address branch September 5, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

+1 more reviewer

@jchen293 jchen293 jchen293 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nwithan8 @jchen293 @Justintime50