fix: go linting on v1.23 #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing with some Go items and found why we couldn't lint on Go 1.23, fixed via this PR.
After talking with the authors of golangci-lint, apparently our linting has just been silently failing for a year or two now because we ignored an inignorable rule but it didn't fail until this most recent version when they patched the silent failing. To correct the linter running, we need to properly name the functions which will remove the ability for them to "run" out of the box because users will need to change the function name to "main"; however, this properly lints the project now and found a dozen issues we needed to fix.