Win' Wind' Windy': First intro scene renders incorrectly #1024

Closed
Ghabry opened this Issue Sep 1, 2016 · 2 comments

Projects

None yet

1 participant

@Ghabry
Member
Ghabry commented Sep 1, 2016 edited

Download: http://www.geocities.jp/viprpg2016gw/entry05.html

Needs "unar" to properly extract.

The rest of the game looks correct. The scene after looks like a LSD trip, that's by design.

Just start the game or watch the gif:

RPG_RT
rpgrt_windy

EasyRPG
easy_windy

@Ghabry Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Sep 1, 2016
@Ghabry Ghabry Variable Operations: Ignore the loop range when only a single value i…
…s set, that range can contain nonsense data.

Fix #1024
e2dad2b
@Ghabry Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Sep 1, 2016
@Ghabry Ghabry Variable Operations: Ignore the loop range when only a single value i…
…s set, that range can contain nonsense data.

Fix #1024
9ddabfb
@Ghabry Ghabry added this to the 0.5.0 milestone Sep 1, 2016
@Ghabry
Member
Ghabry commented Sep 1, 2016 edited

Fixed by 93d0f7a

I wonder why this never caused problems anywhere before

@Ghabry
Member
Ghabry commented Sep 1, 2016

To explain it:

In Variable Operations parameter 0 defines how the variables are set:
0 = Set single variable
1 = Set multiple variables
2 = Set variable indirect

The start variable is in parameter 1. In case of "Multiple variables" the end variable is in parameter 2.

Our code took the same path for single and multiple, this worked because in the single case parameter 2 is the same value as parameter 1. But somehow not in these japanese games.

I wonder how many games this will unbreak :o

@fdelapena fdelapena pushed a commit that closed this issue Sep 2, 2016
@Ghabry Ghabry Variable Operations: Ignore the loop range when only a single value i…
…s set, that range can contain nonsense data.

Fix #1023
Fix #1024
93d0f7a
@fdelapena fdelapena closed this in 93d0f7a Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment