Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change button layout in portrait #1041

Closed
OrdinaryMagician opened this issue Sep 23, 2016 · 9 comments · Fixed by #2699
Closed

Can't change button layout in portrait #1041

OrdinaryMagician opened this issue Sep 23, 2016 · 9 comments · Fixed by #2699
Assignees
Labels
Android Patch available UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design
Milestone

Comments

@OrdinaryMagician
Copy link

Whenever I try to change the buttons, the screen is forced to landscape. Any changes made there completely screw up the layout in portrait.

I don't even know what version I have installed because there's no "about" section or anything in the program, but it should be the latest available on the play store.

@carstene1ns carstene1ns added Android UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design labels Sep 23, 2016
@Ghabry
Copy link
Member

Ghabry commented Sep 23, 2016

That's by design because we assumed nobody uses portrait ;)

@BlisterB. Work for you :D

@BlisterB
Copy link
Member

Hi guys ! I've just obtain my diploma, major of the prom ! Hihihi

I think I'll do a better system next week, it should be possible to change
the layout during a game session.

Le 23 sept. 2016 8:10 PM, "Carsten Teibes" notifications@github.com a
écrit :

Assigned #1041 #1041 to
@BlisterB https://github.com/BlisterB.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1041 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACRuE3bOCDQXuOhLhNopXm_xRyCFsFnlks5qtBYUgaJpZM4KFNv9
.

@OrdinaryMagician
Copy link
Author

That's by design because we assumed nobody uses portrait ;)

woooow, rude!

@Ghabry
Copy link
Member

Ghabry commented Sep 24, 2016

Hm, maybe Portrait is used by some because they want to use it like a gameboy. But depending on the device the game is not always displayed at the top but at the bottom...

@BlisterB
Copy link
Member

@OrdinaryMagician do you really play with portrait mode ?

For the moment, the portrait mode is calculated from the landscape layout. To be able to change the portrait layout, we should force the user to configure separately two layouts. (Or asking a choice between automatic calculation and specific configuration).
We assumed that portrait mode is nearly not used, and because the default layout is good, we didn't add the possibility to change it.

Of course, we are ready to hear any suggestion. But based on our Google Playstore reviews, this features seems worthless (because it would complicate the UI a lot). Please, don't hesitate to answer my question, and describe the way you use our app :).

@fdelapena
Copy link
Contributor

IMo it gets harder to place buttons with some precision, this gets specially tricky when you need to place multiple buttons in a row, they may easily collide or going a bit off screen.
Indeed allowing to setting up them in portrait would be nice (but still force landscape for this if the screen setting checkbox is marked).

@Ghabry
Copy link
Member

Ghabry commented Sep 29, 2016

Maybe don't use two layouts but use one layout and only store the button position for portrait and landscape individually.

Imo a blocker for portrait mode is @BlisterB that it depends on the device if the window is at the top or at the bottom of the screen. In case of top you can hold your smartphone like a gameboy :D

@OrdinaryMagician
Copy link
Author

I really do play in portrait mode. It's more GB-like and it's not as easy to accidentally press certain buttons on the phone (which happens very often when I try to use anything in landscape).

@BlisterB
Copy link
Member

BlisterB commented Oct 2, 2016

Okay, I'll find a clean way to make coexist the actual system and the possibility to customize the portrait mode. I have a thing in mind which would be a good compromise :).

@carstene1ns carstene1ns added this to the 0.5.1 milestone Oct 2, 2016
@Ghabry Ghabry modified the milestones: 0.5.1, 0.6.0 Feb 4, 2017
@carstene1ns carstene1ns changed the title [Android] Can't change button layout in portrait Can't change button layout in portrait Jul 25, 2017
@Ghabry Ghabry modified the milestones: 0.6.1, 0.7.0 May 5, 2019
@Ghabry Ghabry mentioned this issue Mar 30, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Patch available UX For issues affecting the user experience, such annoyances, counter-intuitive or ugly design
Development

Successfully merging a pull request may close this issue.

5 participants