MovePicture does not disable Sine Effect set by ShowPicture #1046

Closed
carstene1ns opened this Issue Oct 1, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@carstene1ns
Member

carstene1ns commented Oct 1, 2016

This affects some games, for example Rosy Despair (and likely the countdown in the Super Smash Brothers clone)

The ShowPicture has Sine with strength 9 set, the first MovePicture has it disabled, the second sets it again:
event

To reproduce in Rosy Despair use --start-map-id 40 --new-game
Here is also a dedicated Testcase: issue1046.zip

Player RPG_RT
player rpg_rt

@Ghabry Ghabry added this to the 0.5.1 milestone Oct 1, 2016

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Oct 3, 2016

Member

Extended the test and filled the top row with combinations of zoom and rotate picture stuff.

issue1046.zip

Member

Ghabry commented Oct 3, 2016

Extended the test and filled the top row with combinations of zoom and rotate picture stuff.

issue1046.zip

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 4, 2017

Member

I can't find my code anymore (maybe I deleted it because I failed). So this issue is free.

Member

Ghabry commented Feb 4, 2017

I can't find my code anymore (maybe I deleted it because I failed). So this issue is free.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Feb 4, 2017

Member

Found some initial code, maybe useful for someone https://gist.github.com/Ghabry/8ffb714aabd6eb0ad26d6732e5c89923

Member

Ghabry commented Feb 4, 2017

Found some initial code, maybe useful for someone https://gist.github.com/Ghabry/8ffb714aabd6eb0ad26d6732e5c89923

@Ghabry Ghabry self-assigned this Mar 4, 2017

@scurest

This comment has been minimized.

Show comment
Hide comment
@scurest

scurest Mar 6, 2017

Contributor

@Ghabry If you didn't get too far on this already, I'm working on #1063 so I'm already touching Game_Picture and can probably do this too.

Contributor

scurest commented Mar 6, 2017

@Ghabry If you didn't get too far on this already, I'm working on #1063 so I'm already touching Game_Picture and can probably do this too.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Mar 6, 2017

Member

@scurest
Great, you can do it if you want. I took 2 days ago another look at this and have a few more lines of code but 75% of my test cases still fail. So feel free to work on it :)

Here is the code: Ghabry@a9373f8

At least the "// Check if enough time left for another full rotation" code works as expected, the other things not really.

Member

Ghabry commented Mar 6, 2017

@scurest
Great, you can do it if you want. I took 2 days ago another look at this and have a few more lines of code but 75% of my test cases still fail. So feel free to work on it :)

Here is the code: Ghabry@a9373f8

At least the "// Check if enough time left for another full rotation" code works as expected, the other things not really.

@Ghabry Ghabry assigned scurest and unassigned Ghabry Mar 6, 2017

scurest added a commit to scurest/Player that referenced this issue Mar 13, 2017

Fix issues with Show/Move Picture commands.
This fixes all of Ghabry's testcases for #1046 in RM2k3.
RM2k does something weird and different.

@carstene1ns carstene1ns closed this in #1126 Mar 16, 2017

@carstene1ns

This comment has been minimized.

Show comment
Hide comment
@carstene1ns

carstene1ns Mar 17, 2017

Member

Forgot to say that the Smash Bros countdown and the Rosy Despair signs are fixed. 👍

Member

carstene1ns commented Mar 17, 2017

Forgot to say that the Smash Bros countdown and the Rosy Despair signs are fixed. 👍

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Fix issues with Show/Move Picture commands.
This fixes all of Ghabry's testcases for #1046 in RM2k3.
RM2k does something weird and different.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment