New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celestial Silfade Story: Freeze after attack command in custom battle system #1064

Closed
kleusbalut opened this Issue Oct 19, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@kleusbalut

kleusbalut commented Oct 19, 2016

thank you for greatest app development.
i've got the bug. report them.

Name of the game:

Celestial Silfade Story ("シルフェイド幻想譚") by SmokingWOLF

Player platform:

Android

Attach files (as a .zip archive or link them)

  • fleeze(no action) on after attack commands. (see attachments)

CvGVGC9UIAETBDc.zip

Download: http://www.silversecond.net/contents/game/silfade_gensou/

Describe the issue in detail and how to reproduce it:

after character making, encount the enemy, input attack command , to freeze.

note: SmokingWOLF apps is very unique battle logic. not on RPG Maker default battle.

@Ghabry Ghabry changed the title from fleeze on after Attack cmds (Celestial Silfade Story) to Celestial Silfade Story: Freeze after attack command in custom battle system Oct 19, 2016

@carstene1ns carstene1ns added the Hang label Mar 12, 2017

@carstene1ns carstene1ns added this to the 0.6.0 milestone Apr 17, 2017

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry Aug 12, 2017

Member

The bug here is again a misalignment when scrolling the screen (this broke smash bros e.g.)

Relevant Code in Common Event 109:

@> Control Variables: [0441:中心座標X] = Player's X Coordinate
@> Control Variables: [0442:中心座標Y] = Player's Y Coordinate
@> Control Variables: [0443:アニメ最終表示X] = Player's Screen X
@> Loop
  @> Conditional Branch: Variable [0443:アニメ最終表示X] > 152
    @> Conditional Branch: Variable [0443:アニメ最終表示X] == 152
      @> Break Loop
      @>
     : Branch End
    @> Control Variables: [0441:中心座標X] -= 1 
    @> Control Variables: [0443:アニメ最終表示X] -= 16 
    @>
   : Else
    @> Conditional Branch: Variable [0443:アニメ最終表示X] == 152
      @> Break Loop
      @>
     : Branch End
    @> Control Variables: [0441:中心座標X] += 1 
    @> Control Variables: [0443:アニメ最終表示X] += 16 
    @>
   : Branch End
  @>
 : Repeat Above

The code basicly takes the X Screen position of the Player and adds/substracts 16 until the variable is 152 (which is the break condition).

For this code to terminate the X position must be on a 16-pixel grid (and 8 added because 152 has is not a dividing 16), as a formula the X position must be a solution of this equation.
A * 16 + 8

In Player the X position is 151, which is obviously wrong. :/

Member

Ghabry commented Aug 12, 2017

The bug here is again a misalignment when scrolling the screen (this broke smash bros e.g.)

Relevant Code in Common Event 109:

@> Control Variables: [0441:中心座標X] = Player's X Coordinate
@> Control Variables: [0442:中心座標Y] = Player's Y Coordinate
@> Control Variables: [0443:アニメ最終表示X] = Player's Screen X
@> Loop
  @> Conditional Branch: Variable [0443:アニメ最終表示X] > 152
    @> Conditional Branch: Variable [0443:アニメ最終表示X] == 152
      @> Break Loop
      @>
     : Branch End
    @> Control Variables: [0441:中心座標X] -= 1 
    @> Control Variables: [0443:アニメ最終表示X] -= 16 
    @>
   : Else
    @> Conditional Branch: Variable [0443:アニメ最終表示X] == 152
      @> Break Loop
      @>
     : Branch End
    @> Control Variables: [0441:中心座標X] += 1 
    @> Control Variables: [0443:アニメ最終表示X] += 16 
    @>
   : Branch End
  @>
 : Repeat Above

The code basicly takes the X Screen position of the Player and adds/substracts 16 until the variable is 152 (which is the break condition).

For this code to terminate the X position must be on a 16-pixel grid (and 8 added because 152 has is not a dividing 16), as a formula the X position must be a solution of this equation.
A * 16 + 8

In Player the X position is 151, which is obviously wrong. :/

@carstene1ns carstene1ns modified the milestones: 0.5.3, 0.6.0 Aug 12, 2017

carstene1ns added a commit that referenced this issue Aug 18, 2017

Merge pull request #1245 from Ghabry/issue-1064
Fix #1064 (Celestial Silfade Story (シルフェイド幻想譚)) and timer rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment