Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"monster died" message doesn't show in battle #1102

Closed
msikma opened this Issue Feb 15, 2017 · 2 comments

Comments

Projects
None yet
5 participants
@msikma
Copy link

msikma commented Feb 15, 2017

Video of the issue. This was made using the elf file of build 120. Compare to the original.

Seems that the message "<monster name> died" isn't being printed when a monster dies.

edit: whoops, forgot < tags need escaping

@fdelapena fdelapena added the Battle label Feb 16, 2017

@carstene1ns carstene1ns changed the title 3DS: "monster died" message doesn't show in battle "monster died" message doesn't show in battle Apr 17, 2017

@carstene1ns carstene1ns added this to the 0.6.0 milestone Apr 17, 2017

Albeleon added a commit to Albeleon/Player that referenced this issue Jun 23, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

Albeleon added a commit to Albeleon/Player that referenced this issue Jun 24, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.
@Ghabry

This comment has been minimized.

Copy link
Member

Ghabry commented Jun 25, 2018

@Albeleon this has a patch in your PR?

Albeleon added a commit to Albeleon/Player that referenced this issue Jun 29, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

Albeleon added a commit to Albeleon/Player that referenced this issue Jul 1, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

Albeleon added a commit to Albeleon/Player that referenced this issue Jul 2, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

Albeleon added a commit to Albeleon/Player that referenced this issue Jul 4, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.
@Albeleon

This comment has been minimized.

Copy link
Member

Albeleon commented Jul 7, 2018

#1373
"2.6 + 3.7"
"Big commit: Issues fixed: 2.2 + 3.1 + 3.2"
These two commit implement this correctly now.

@Ghabry Ghabry modified the milestones: 0.6.0, 0.5.4 Jul 7, 2018

Albeleon added a commit to Albeleon/Player that referenced this issue Jul 8, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

Albeleon added a commit to Albeleon/Player that referenced this issue Jul 12, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

Albeleon added a commit to Albeleon/Player that referenced this issue Jul 16, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 14, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 14, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 15, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 17, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 27, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Oct 27, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 4, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 5, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 5, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 5, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 5, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 5, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 6, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 6, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 6, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.

fmatthew5876 added a commit to fmatthew5876/Player that referenced this issue Nov 6, 2018

2.6 + 3.7
"2.6: RM2000 (issue EasyRPG#1102 ): When an enemy dies, a message should be displayed right after the attack inside the same message."
"3.7: RM2000: If an enemy dies with an attack that takes away many stats HP included (or puts conditions), the enemy should die right after the HP damage is done, and the other messages are ignored. This also includes absorb attacks."

Solution: We push that messages after the damage if the enemy is dead, and it skips the rest of result messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.