New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero Graphic changed by Move Route must always reset after Teleport #1111

Closed
Ghabry opened this Issue Mar 4, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@Ghabry
Member

Ghabry commented Mar 4, 2017

TestCase:
Change Hero Graphic with "Move Route -> Change Graphic" and walk on a teleport.

Expected behaviour: The heros graphic is reset. In EasyRPG this only happens when the teleport goes to a different map, on the same map it remains at the changed (wrong). in RPG_RT it changes for all teleports, independend of the target map.

Not sure if this also applies to other move route attributes. Only tested with "Through", that is not reset.

@carstene1ns carstene1ns added this to the 0.6.0 milestone Mar 5, 2017

@carstene1ns carstene1ns modified the milestones: 0.5.2, 0.6.0 Apr 17, 2017

@rohkea

This comment has been minimized.

Show comment
Hide comment
@rohkea

rohkea Apr 22, 2017

Member

Fox Pac Quest is affected by this. When the hero is caught, his graphics is changed via Move Event to an auxillary charset. This auxillary charset contains ‘caught’ graphics, some other graphics, and a hammer, so, when facing right, the hero becomes a hammer xD

screenshot_3

Member

rohkea commented Apr 22, 2017

Fox Pac Quest is affected by this. When the hero is caught, his graphics is changed via Move Event to an auxillary charset. This auxillary charset contains ‘caught’ graphics, some other graphics, and a hammer, so, when facing right, the hero becomes a hammer xD

screenshot_3

@Ghabry Ghabry self-assigned this May 28, 2017

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 28, 2017

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 28, 2017

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 6, 2017

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 17, 2017

carstene1ns added a commit that referenced this issue Jun 23, 2017

Ghabry added a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment