New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep 8: Birds shot in "Cannon game" minigame are sometimes not playing the dead animation #1112

Closed
Ghabry opened this Issue Mar 4, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@Ghabry
Member

Ghabry commented Mar 4, 2017

Name of the game: Deep 8

I included a minimal testcase that has the same issue.

Attach files (as a .zip archive or link them)

issue1112.zip

Describe the issue in detail and how to reproduce it:

In front of you are 4 bridges, pressing ENTER on one of these bridges "kills" a bird. This is some jump-event combined with a rotation. In EasyRPG that jump-kill is sometimes not executed and the bird dissapears directly. In RPG_RT the anim is always played.

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry May 26, 2017

Member

The animaton only works when the movement pattern is on frame 1 (middle frame) while it happens. On frame 0, 2 (left, right) the bird just dissapears. (actually I think the wrong frame is shown which is empty in this charset)

Member

Ghabry commented May 26, 2017

The animaton only works when the movement pattern is on frame 1 (middle frame) while it happens. On frame 0, 2 (left, right) the bird just dissapears. (actually I think the wrong frame is shown which is empty in this charset)

@Ghabry

This comment has been minimized.

Show comment
Hide comment
@Ghabry

Ghabry May 26, 2017

Member

This is caused by the following code in Game_Event::Setup and is fixed by removing the if-check.

	if (original_pattern != page->character_pattern) {
		pattern = page->character_pattern;
		original_pattern = pattern;
	}

git blame says the code was added by me 6 years ago :o

This needs regression tests but imo that if-check makes no sense because it prevents the events current pattern to change when the old and the new page used the same pattern setting. (and the current pattern can be different due to movements)

Or that check became useless in the meanwhile because other code fixed what this code was originally supposed to do?

Member

Ghabry commented May 26, 2017

This is caused by the following code in Game_Event::Setup and is fixed by removing the if-check.

	if (original_pattern != page->character_pattern) {
		pattern = page->character_pattern;
		original_pattern = pattern;
	}

git blame says the code was added by me 6 years ago :o

This needs regression tests but imo that if-check makes no sense because it prevents the events current pattern to change when the old and the new page used the same pattern setting. (and the current pattern can be different due to movements)

Or that check became useless in the meanwhile because other code fixed what this code was originally supposed to do?

@Ghabry Ghabry self-assigned this May 28, 2017

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue May 28, 2017

Remove pattern check in Event-Setup.
The purpose of this check is unknown and breaks a bird shooting minigame in Deep8.

Fix #1112

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 6, 2017

Remove pattern check in Event-Setup.
The purpose of this check is unknown and breaks a bird shooting minigame in Deep8.

Fix #1112

Ghabry added a commit to Ghabry/easyrpg-player that referenced this issue Jun 17, 2017

Remove pattern check in Event-Setup.
The purpose of this check is unknown and breaks a bird shooting minigame in Deep8.

Fix #1112

carstene1ns added a commit that referenced this issue Jun 23, 2017

Ghabry added a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Remove pattern check in Event-Setup.
The purpose of this check is unknown and breaks a bird shooting minigame in Deep8.

Fix #1112

Ghabry pushed a commit to libretro/easyrpg-libretro that referenced this issue May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment